This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Inconsistent page.date handling #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent, thanks a lot! |
laedit
pushed a commit
that referenced
this pull request
Aug 4, 2015
Inconsistent page.date handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the handling of
page.dateis inconsistent:page.Bag["date"]is aDateTimepage.Bag["date"]is astring(as parsed by YamlDotNet)When you're using
{{ page.date | date_to_xmlschema }}on your template, andpage.Bag["date"]is astring, it will be rendered asLiquid error: Object of type 'System.String' cannot be converted to type 'System.DateTime'.This PR fixes this by always adding the date back to
page.Bag["date"]asDateTime(in fact I only had to delete some code inSiteContextGenerator.cs. 😉) Two other tests relied on strings, which I fixed.